Message Compatibility Tests #765
Conversation
data/Cargo.toml
Outdated
| irc_2025_1 = { git = "https://github.com/squidowl/halloy.git", tag = "2025.1", package = "irc" } | ||
| data_2025_1 = { git = "https://github.com/squidowl/halloy.git", tag = "2025.1", package = "data" } | ||
|
|
There was a problem hiding this comment.
This is mega cursed, we will link to all past versions this way, which will grow linearly with each new version.
I'd rather see static json test fixtures for all known existing variants and just attempt to Deserialize it. If it fails, we have a breakage.
We will obviously need to update these tests as we add new forward compatible fields
There was a problem hiding this comment.
It is indeed mega-cursed! I think I mislabeled my tests, so for clarity I'm going to avoid using the terms forward/backward compatibility for the moment. If we have static json test fixtures for all known existing variants we can ensure the current version can read all older serialized messages, but we can't ensure old versions can read the current version's serialized messages. I was operating under the assumption that we wanted tests to ensure users could downgrade as well.
Normally I'd try and build these tests into an exterior system, but I wasn't sure which would be appropriate here.
Adds some forward and backward compatibility tests with release version 2025.1 for (de)serializing messages.