Squiz.PHP.DisallowMultipleAssignmentsSniff: Fixed false positive when…

… assigment is after goto label
squizlabs · Apr 8, 2021 · 557756c · 557756c
1 parent c19a0f5
commit 557756c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Standards/Squiz/Sniffs/PHP/DisallowMultipleAssignmentsSniff.php b/src/Standards/Squiz/Sniffs/PHP/DisallowMultipleAssignmentsSniff.php
@@ -146,6 +146,7 @@ public function process(File $phpcsFile, $stackPtr)
 
         if ($tokens[$varToken]['code'] === T_VARIABLE
             || $tokens[$varToken]['code'] === T_OPEN_TAG
+            || $tokens[$varToken]['code'] === T_GOTO_LABEL
             || $tokens[$varToken]['code'] === T_INLINE_THEN
             || $tokens[$varToken]['code'] === T_INLINE_ELSE
             || $tokens[$varToken]['code'] === T_SEMICOLON

diff --git a/src/Standards/Squiz/Tests/PHP/DisallowMultipleAssignmentsUnitTest.inc b/src/Standards/Squiz/Tests/PHP/DisallowMultipleAssignmentsUnitTest.inc
@@ -98,3 +98,13 @@ function ($html) {
         return $all;
     }, $html);
 };
+
+
+function () {
+    $a = false;
+
+    some_label:
+
+    $b = getB();
+};
+