-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Testing removal of PHPCS from the composer autoloader
- Loading branch information
Showing
2 changed files
with
5 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
566a0cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for that? Now I have to autoload these classes extra manually :(
566a0cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomasVotruba Part of #1333
If you need to include PHPCS directly, include the autoload.php file. For anyone not using PHPCS as a lib, they shouldn't include this file or else PHPCS will try and autoload and track classes, which is why it was removed.
566a0cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see solution in breaking non-framework usage.
566a0cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For anyone else looking for solution for this composer break, you can find it on StackOverfelow.
Let me know there if you find better one or if this was already solved.
566a0cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is the root of the issue that is causing our 3.x development to error as follows
566a0cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@photodude I think your issue is probably related to #1564 which should be fixed in the latest PHPCS
master
.566a0cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@photodude @jrfnl That issue was only during testing. So if you are getting this problem during a normal phpcs run, then you've probably got a namespace issue somewhere. Namespace requirements are described in the upgrade guide (https://github.com/squizlabs/PHP_CodeSniffer/wiki/Version-3.0-Upgrade-Guide#upgrading-custom-sniffs) but please create a new issue with a link to your coding standard (if possible) if you are having a problems.