Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very large reports can sometimes become garbled when using the parallel option #1746

Closed
b0nd0 opened this issue Nov 8, 2017 · 1 comment
Closed

Very large reports can sometimes become garbled when using the parallel option #1746

b0nd0 opened this issue Nov 8, 2017 · 1 comment
Labels
Type: bug
Milestone
3.2.0

Comments

@b0nd0
Copy link

b0nd0 commented Nov 8, 2017

I used --parallel=10 with --report=json on our legacy codebase, and got almost 60 megabytes error report with invalid json inside.
Some parts overlaps, like some kind of race conditions:

...,"source":"Generic.WhiteSpace.ScopeIndent.IncorrectEx"\/another\/file\/path\/file.php":{"errors":159,"warnings":7,...
@gsherwood gsherwood changed the title race conditions in --parallel Very large reports can sometimes become garbled when using the parallel option Nov 8, 2017
gsherwood added a commit that referenced this issue Nov 8, 2017
@gsherwood
Fixed bug #1746 : Very large reports can sometimes become garbled whe…
53ba7e2 
…n using the parallel option
@gsherwood
Copy link
Member

Thanks for reporting this. A lock wasn't being acquired when appending a cached report to the temp file, so I've fixed that.

@gsherwood gsherwood added this to the 3.2.0 milestone Nov 8, 2017
@dependencies dependencies bot mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
2 participants
@gsherwood @b0nd0