Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject the Config in the Runner constructor #3882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BafS
Copy link

@BafS BafS commented Aug 28, 2023

Inject the configuration object in the constructor instead of creating the instance without having the ability to change it.

Currently it's not possible to change the configuration because it's using in a "black box" way. This PR proposes to use dependency injection to have more control over it when using the library in a programmatic way.

Suggested changelog entry

  • Add the ability to inject the Config object in the Runner class

Related issues/external references

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes. (should not be needed in this case, already covered)
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
  • [Required for new files] I have added any new files to the package.xml file.

@BafS BafS changed the title Inject the Config in the constructor Inject the Config in the Runner constructor Aug 28, 2023
@jrfnl
Copy link
Contributor

jrfnl commented Aug 28, 2023

Marking as "Close candidate" - see the discussion in #3697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants