Add sniff for FIXME comments as errors to TodoSniff. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the concept of a FIXME sniff is good, but I don't think it belongs in the TODO sniff. It changes the behaviour of this sniff so it no longer does what the documentation says it does. It also uses errors instead of warnings, which makes the sniff stronger than it currently it. Do you want to just create a new sniff for this, and unit tests, and I'll merge that in? I know it seems like a copy/paste job, but I think it then keeps the intention of the sniffs clear. |
|
Good points, I was half wondering myself if I should have done that. I'll close this pull request and submit another once I'm done. |
rhowardiv
referenced
this pull request
in rhowardiv/PHP_CodeSniffer
Feb 15, 2013
Remove line breaks from error/warning messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to add FIXME comments to the TODO comments sniff: FIXME comments produce an error rather than a warning, and have FixmeCommentFound or FixmeTaskFound message class.
Updated tests included (and test-suite passes successfully).