Raise exception in comparison between different types

sr-lab · Sep 22, 2023 · c1188ca · c1188ca
1 parent 5ef87c2
commit c1188ca
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/pylspclient/lsp_structs.py b/pylspclient/lsp_structs.py
@@ -38,10 +38,9 @@ def __eq__(self, __value: object) -> bool:
         )
 
     def __gt__(self, __value: object) -> bool:
-        return isinstance(__value, Position) and (self.line, self.character) > (
-            __value.line,
-            __value.character,
-        )
+        if not isinstance(__value, Position):
+            raise TypeError(f"Invalid type for comparison: {type(__value).__name__}")
+        return (self.line, self.character) > (__value.line, __value.character)
 
     def __lt__(self, __value: object) -> bool:
         return not self.__eq__(__value) and not self.__gt__(__value)