Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Coq 8.19 #40

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Support Coq 8.19 #40

merged 6 commits into from
Feb 15, 2024

Conversation

pcarrott
Copy link
Collaborator

  • Accessed fields in a VernacExtend AST are in a dictionary instead of list in the new Coq version
  • The notation for forall changed the associativity level, so the tests now depend on the Coq version

@pcarrott pcarrott requested a review from Nfsaavedra February 15, 2024 15:13
Nfsaavedra
Nfsaavedra requested changes Feb 15, 2024
View reviewed changes
coqpyt/tests/proof_file/utility.py Show resolved Hide resolved
coqpyt/tests/proof_file/utility.py Outdated Show resolved Hide resolved
Nfsaavedra
Nfsaavedra approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@Nfsaavedra Nfsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nfsaavedra Nfsaavedra merged commit ff4420c into master Feb 15, 2024
2 checks passed
@Nfsaavedra Nfsaavedra deleted the coq_v819 branch February 15, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nfsaavedra Nfsaavedra Nfsaavedra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcarrott @Nfsaavedra