Add caching on disk #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nfsaavedra
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Yap, this is very important and useful! Thanks!
It's true that the hash does not consider the dependencies and that may affect correctness if the files in the dependencies change, but I believe that's a trade-off we have to accept. Can you please add a comment to the doc string of ProofFile mentioning that? Also, I suggest to add a static method to the ProofFile class that allows to toggle the disk cache. Other than that, LGTM, thanks! 😄
|
I added documentation on the ProofFile object, and made it optional (off by default). I also added a test for the disk caching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start thinking about caching file context on disk so that cached proof files are available across processes. Here are the possible issues with this implementation:
With that being said this significantly speeds up time for ProofFiles.
For example, the tests go from 94s to 55s on subsequent runs.
Time to run a Proof File for Sudoku.v in the Sudoku repo goes from 199s to 33s.
I think this is important since many files share dependencies even if they are in different projects.