Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhoc handling of custom entries for notations and improvements on plugins (VernacExtend) #51

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

pcarrott
Copy link
Collaborator

@pcarrott pcarrott commented Oct 3, 2024

  • To handle InCustomEntry from the AST, only consider notations with a non-empty pattern for the step context.
  • A single notation might yield multiple Locate results. We now iterate over all, instead of just trying the first one.
  • AST nodes with GenArg now (partially) support ListArg, besides ExtraArg.
  • Plugin for Coq-Equations is now recognized by FileContext.

@pcarrott pcarrott requested a review from Nfsaavedra October 3, 2024 22:20
@Nfsaavedra
Copy link
Member

Are there any simple examples to test what was changed? At least the second and third point. I believe the last one would require adding Coq-Equations to our test setup.

Copy link
Member

@Nfsaavedra Nfsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, we should probably wait for the issue with the menhir package to be fixed, re-run the CI, and only then merge.

@pcarrott pcarrott merged commit bfa476a into master Oct 16, 2024
4 checks passed
@pcarrott pcarrott deleted the notations_and_plugins branch October 16, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants