refactor: tweak ContinuedFraction.convergent method to pass in the full sequence of elements
#36
Labels
Comments
sr-murthy
added
refactor
sr-murthy
added a commit
that referenced
this issue
Mar 17, 2024
…lib.convergent` will the full sequence of elements
sr-murthy
added a commit
that referenced
this issue
Mar 17, 2024
…o pass the full sequence of elements to `lib.convergent` + add cached properties to get all convergents and all remainders
Merged
sr-murthy
added a commit
that referenced
this issue
Mar 17, 2024
* chore: bump version refs to `0.11.18` * fix: fixes issue #36: `ContinuedFraction.convergent` method to call `lib.convergent` will the full sequence of elements * fix: add some missing type hinting in `ContinuedFraction` methods * refactor: tweak `ContinuedFraction` class to add slots and mypy Final typing for elements instance attribute * refactor: `functools` caching for some `ContinuedFraction` methods and properties * feat: closes issues #35, #36: `ContinuedFraction.convergent` method to pass the full sequence of elements to `lib.convergent` + add cached properties to get all convergents and all remainders * docs: tweak contributions page to add note to built Sphinx docs locally * refactor: more intuitive variable naming in `lib.fraction_from_elements`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ATM the
continuedfraction.ContinuedFraction.convergentmethod calls thelib.convergentmethod with thek-th segment (CF with the firstk + 1elements of the original).As the
k-th convergent is uniquely determined by thek-th segment this works fine, but by designlib.convergentshould be given the full sequence of elements of the original.The text was updated successfully, but these errors were encountered: