Skip to content

Commit

Permalink
Revert "Deprecate --resources-dir option. (dart-lang#3696)"
Browse files Browse the repository at this point in the history
This reverts commit cec45fb.
  • Loading branch information
srawlins committed Jun 7, 2024
1 parent 3decf1e commit 4bdbf92
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 14 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 8.0.10-dev

* Un-deprecate the `--resources-dir` option.

## 8.0.9

* Deprecate the `missingCodeBlockLanguage` warning. This is replaced with the
Expand Down
2 changes: 1 addition & 1 deletion dartdoc_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
dartdoc:
linkToSource:
root: '.'
uriTemplate: 'https://github.com/dart-lang/dartdoc/blob/v8.0.9/%f%#L%l%'
uriTemplate: 'https://github.com/dart-lang/dartdoc/blob/v8.0.10-dev/%f%#L%l%'
6 changes: 2 additions & 4 deletions lib/src/dartdoc_options.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1669,11 +1669,9 @@ List<DartdocOption> createDartdocOptions(
help:
'A list of package names to place first when grouping libraries in '
'packages. Unmentioned packages are placed after these.'),
// Deprecated. Use of this option is reported.
// TODO(kallentu): Remove this option.
// TODO(srawlins): Deprecate this option.
DartdocOptionArgOnly<String?>('resourcesDir', null, resourceProvider,
help: "(deprecated) An absolute path to dartdoc's resources directory.",
hide: true),
help: "An absolute path to dartdoc's resources directory.", hide: true),
DartdocOptionArgOnly<bool>('sdkDocs', false, resourceProvider,
help: 'Generate ONLY the docs for the Dart SDK.'),
DartdocOptionArgSynth<String?>('sdkDir',
Expand Down
7 changes: 0 additions & 7 deletions lib/src/generator/generator_frontend.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ class GeneratorFrontEnd implements Generator {
'longer be supported.',
);
}
if (_generatorBackend.options.resourcesDir != null) {
packageGraph?.defaultPackage.warn(
PackageWarning.deprecated,
message: "The '--resources-dir' option is deprecated, and will soon be "
'removed.',
);
}

await _generatorBackend.generateAdditionalFiles();

Expand Down
2 changes: 1 addition & 1 deletion lib/src/version.dart
Original file line number Diff line number Diff line change
@@ -1 +1 @@
const packageVersion = '8.0.9';
const packageVersion = '8.0.10-dev';
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: dartdoc
version: 8.0.9
version: 8.0.10-dev
description: A non-interactive HTML documentation generator for Dart source code.
repository: https://github.com/dart-lang/dartdoc

Expand Down

0 comments on commit 4bdbf92

Please sign in to comment.