Fix dart-lang#385 dart-lang#388 dart-lang#398 @lasse Nielsen

srburton · Jan 25, 2023 · d66aad9 · d66aad9
1 parent c565d4f
commit d66aad9
Showing 1 changed file with 21 additions and 12 deletions.
diff --git a/sdk/lib/_internal/js_runtime/lib/js_helper.dart b/sdk/lib/_internal/js_runtime/lib/js_helper.dart
@@ -380,22 +380,31 @@ class Primitives {
   }
 
   static bool? parseBool(String source, bool caseSensitive) {
-    checkNotNullable(source, "source");    
+    checkNotNullable(source, "source");
+    checkNotNullable(caseSensitive, "caseSensitive");
     //The caseSensitive defaults to true.
-    if (caseSensitive == null || caseSensitive == true) 
-      return source == "true" ? true : source == "false" ? false : null;     
-    //Ignore case-sensitive when caseSensitive is false.                                      
-    return _compareIgnoreCase(source, "true")? true : _compareIgnoreCase(source, "false")? false : null;
+    if (caseSensitive == null || caseSensitive == true)
+      return source == "true"
+          ? true
+          : source == "false"
+              ? false
+              : null;
+    //Ignore case-sensitive when caseSensitive is false.
+    return _compareIgnoreCase(source, "true")
+        ? true
+        : _compareIgnoreCase(source, "false")
+            ? false
+            : null;
   }
 
   static bool _compareIgnoreCase(String input, String lowerCaseTarget) {
-   if (input.length != lowerCaseTarget.length) return false;
-   for (var i = 0; i < input.length; i++) {
-     if (input.codeUnitAt(i) | 0x20 != lowerCaseTarget.codeUnitAt(i)) {
-       return false;
-     }
-   }
-   return true;
+    if (input.length != lowerCaseTarget.length) return false;
+    for (var i = 0; i < input.length; i++) {
+      if (input.codeUnitAt(i) | 0x20 != lowerCaseTarget.codeUnitAt(i)) {
+        return false;
+      }
+    }
+    return true;
   }
 
   /// [: r"$".codeUnitAt(0) :]