Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks to latest Enry and Github-Linguist #184

Merged
merged 3 commits into from
Dec 28, 2018

Conversation

bzz
Copy link
Contributor

@bzz bzz commented Dec 26, 2018

Fixes #149

Compares enry v1.6.7 vs linguist v7.1.3 using existing benchmarks.

TODOs:

  • update instructions on reproducing benchmarks
  • run "fast" benchmarks locally
  • run all benchmarks, post results (takes 15h)
  • document exact Linguist and Enry revisions in benchmark results

Current benchmark

New benchmark

distribution

@bzz bzz requested review from creachadair and dennwc December 26, 2018 21:13
@bzz bzz self-assigned this Dec 26, 2018
@creachadair
Copy link
Contributor

This appears to have been pre-merged with #183. Could you please rebase after that lands so I can see what's left of the difference?

bzz added 3 commits December 27, 2018 14:50
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
@bzz bzz force-pushed the maintenance/update-benchmark branch from 3d356c7 to 890afc4 Compare December 27, 2018 13:53
@bzz
Copy link
Contributor Author

bzz commented Dec 27, 2018

Could you please rebase after that lands so I can see what's left of the difference?

Sure, it's just a workflow that we use in case bunch of PRs depend on one another, and that is the reason the exact commit to be reviewed was linked in PR description.

BTW it is also a convention that a WIP in the title means that it's still work in progress and is just open for preliminary feedback, rather then final review, so 👍

Done, finished and ready for review now!

@bzz bzz changed the title WIP: Update benchmarks to latest Enry and Github-Linguist Update benchmarks to latest Enry and Github-Linguist Dec 27, 2018
@creachadair
Copy link
Contributor

Sure, it's just a workflow that we use in case bunch of PRs depend on one another, and that is the reason the exact commit to be reviewed was linked in PR description.

Makes sense! I just saw a review request pop up and figured therefore that it must be ready.

@bzz bzz merged commit f28fc12 into src-d:master Dec 28, 2018
@bzz bzz deleted the maintenance/update-benchmark branch December 28, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants