memfs: Fix memory FS implementation bug #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 83.71% 84.34% +0.62%
==========================================
Files 5 5
Lines 393 396 +3
==========================================
+ Hits 329 334 +5
+ Misses 39 37 -2
Partials 25 25
Continue to review full report at Codecov.
|
ajnavarro
force-pushed
the
fix/memory-seek-and-write-oob
branch
from
d94fb79 to
68627ec
Compare
Now, using memory FS, is possible to seek outside the size of the file and write something, adding '0' between the old file content and the new one.
ajnavarro
force-pushed
the
fix/memory-seek-and-write-oob
branch
from
68627ec to
85a405f
Compare
mcuadros
approved these changes
Apr 12, 2017
alcortesm
approved these changes
Apr 12, 2017
bzz
approved these changes
Apr 12, 2017
Merged
mcuadros
force-pushed
the
master
branch
5 times, most recently
from
96429fb to
88d97b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, using memory FS, is possible to seek outside the size of the file and write something, adding '0' between the old file content and the new one.