memfs: bug fixing #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 90.2% 90.27% +0.06%
==========================================
Files 6 6
Lines 429 432 +3
==========================================
+ Hits 387 390 +3
Misses 23 23
Partials 19 19
Continue to review full report at Codecov.
|
ajnavarro
force-pushed
the
fix/seek-file-position
branch
2 times, most recently
from
f0b43b8 to
0db0771
Compare
mcuadros
suggested changes
Apr 18, 2017
test/fs_suite.go
Outdated
| @@ -715,6 +715,57 @@ func (s *FilesystemSuite) TestReadAtOnReadOnly(c *C) { | |||
| c.Assert(f.Close(), IsNil) | |||
| } | |||
|
|
|||
| func (s *FilesystemSuite) TestWriteAndRead(c *C) { | |||
There was a problem hiding this comment.
since you are testing two bugs, maybe you can create two tests
ajnavarro
force-pushed
the
fix/seek-file-position
branch
from
0db0771 to
be99196
Compare
In this PR we fix two different bugs in memfs implementation: - Using ReadAt, if the provided slice of bytes has a size bigger than the data to read, it must return the result and a io.EOF error. - ReadAt must not affect to the offset position: https://golang.org/src/io/io.go?s=7545:7620#L203
ajnavarro
force-pushed
the
fix/seek-file-position
branch
from
be99196 to
4b48e46
Compare
alcortesm
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we fix two different bugs in memfs implementation: