This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
git: remove potentially duplicate check for unstaged files #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Meinhardt <tobias.meinhardt89@gmail.com>
kunickiaj
pushed a commit
to kunickiaj/beer
that referenced
this pull request
Jul 10, 2019
After src-d/go-git#1081 was merged, the performance seems to be significantly better (usable). Even if a slight bit slower, this means theres no more CGO dependency making it much more portable.
kunickiaj
pushed a commit
to kunickiaj/beer
that referenced
this pull request
Jul 10, 2019
* Switch to go-git for a pure golang implementation After src-d/go-git#1081 was merged, the performance seems to be significantly better (usable). Even if a slight bit slower, this means theres no more CGO dependency making it much more portable. * Format cmd/brew.go Co-Authored-By: fixmie[bot] <44270338+fixmie[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you checkout a branch, you already look in the
Resetmethod for unstaged files(https://github.com/meinto/go-git/blob/master/worktree.go#L272-L281).
That's why I think the check in the
Checkoutmethod is not necessary.This would also increase the performance of the
Checkoutmethod, becausecontainsUnstagedChangescontains a method call ofmerkletrie.DiffTreewhich takes very long on large projects:#758 (comment)