-
Notifications
You must be signed in to change notification settings - Fork 109
Conversation
Signed-off-by: kuba-- <kuba@sourced.tech>
} | ||
|
||
return idx | ||
return r.indexes[indexKey{db, strings.ToLower(id)}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we remove this, can't queries use indexes while it's still being created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine. I've double checked it. For regular queries we use IndexByExpression
function where we still have the check:
if !r.canUseIndex(idx) {
continue
}
Signed-off-by: kuba-- <kuba@sourced.tech>
we are not testing deletion of index with several expressions: https://codecov.io/gh/src-d/go-mysql-server/compare/ad0eefd9bc595f6768de9f49c03f44e0c0f0e2e7...4e50b69e441c054a50523e475cd0fbf777046c51/src/sql/index/pilosa/driver.go#L372 can you check that? |
Signed-off-by: kuba-- <kuba@sourced.tech>
Signed-off-by: kuba-- <kuba@sourced.tech>
@ajnavarro - I've added |
Signed-off-by: kuba-- kuba@sourced.tech
Closes #343
Changes:
Right now we can drop/cancel indexes in progress.
Function
IndexesByTable
returns all indexes (NotReady
as well), so if you want to know status you have to callCanUseIndex
.Delete index uses
force
flag (what cancel the context what breaks and deletes the index).SHOW INDEX FROM...
shows all indexes, butNotReady
indexes have NO in columnVisible
, otherwise YES.