This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
For "set @@session.autocommit" replace on/1, off/0. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kuba-- <kuba@sourced.tech>
|
@src-d/data-retrieval mysql tests are failing due to: So this PR also is failing (because it was branched from the master). |
erizocosmico
suggested changes
Sep 25, 2018
| @@ -35,6 +35,7 @@ var ( | |||
| showIndexRegex = regexp.MustCompile(`^show\s+(index|indexes|keys)\s+(from|in)\s+\S+\s*`) | |||
| describeRegex = regexp.MustCompile(`^(describe|desc|explain)\s+(.*)\s+`) | |||
| fullProcessListRegex = regexp.MustCompile(`^show\s+(full\s+)?processlist$`) | |||
| setAutocommitRegexp = regexp.MustCompile(`^set\s+(@+)session.autocommit\s*=`) | |||
There was a problem hiding this comment.
there is already support for set in go-mysql-server, there is no need to add a regexp for this
There was a problem hiding this comment.
Yes, but because ON is a keyword, yacc Parse fails. That's why I first converts on/off to 1/0 and pass through regular workflow.
There was a problem hiding this comment.
Then maybe we can pre-process the query and replace the on/off with 1/0 before actually parsing it using sqlparser. There might be other queries that use on/off, this is very ad-hoc.
ajnavarro
suggested changes
Sep 25, 2018
|
I'm closing this one. Hopefully we can get it for free after upgrade vitess to v2.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
This is workaround which for queries
SET @@session.autocommitreplacesONby1andOFFby0.At least it fixes #374