This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
*: add information_schema db with files and column_statistics tables #430
Merged
ajnavarro
merged 1 commit into
src-d:master
from
mcarmonaa:feature/add-information-schema-db
Oct 17, 2018
Merged
*: add information_schema db with files and column_statistics tables #430
ajnavarro
merged 1 commit into
src-d:master
from
mcarmonaa:feature/add-information-schema-db
Oct 17, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI is not passing. Can you rebase please? |
erizocosmico
suggested changes
Oct 9, 2018
information_schema.go
Outdated
|
||
// PartitionRows implements the sql.Table interface. | ||
func (t *emptyTable) PartitionRows(_ *sql.Context, _ sql.Partition) (sql.RowIter, error) { | ||
return new(rowIter), nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, delete rowIter
and use sql.RowsToRowIter()
, which returns an empty iterator
|
||
// Partitions implements the sql.Table interface. | ||
func (t *emptyTable) Partitions(_ *sql.Context) (sql.PartitionIter, error) { | ||
return new(partitionIter), nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This iterator should return no partitions
mcarmonaa
force-pushed
the
feature/add-information-schema-db
branch
4 times, most recently
from
October 12, 2018 08:35
8e12e42
to
7b4d838
Compare
erizocosmico
approved these changes
Oct 17, 2018
@mcarmonaa can you rebase please? |
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
mcarmonaa
force-pushed
the
feature/add-information-schema-db
branch
from
October 17, 2018 08:47
7b4d838
to
cda738a
Compare
rebased |
ajnavarro
approved these changes
Oct 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after @erizocosmico comments.
@ajnavarro those comments are already addressed 👍 |
CI is failing because it can't download JDK |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #424
Closes #408