This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql/(parse,expression): implement unary minus #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
force-pushed
the
feature/negative-numbers
branch
from
452abbf
to
5fcef29
Compare
kuba--
reviewed
Oct 16, 2018
| } | ||
| } | ||
|
|
||
| switch n := child.(type) { |
There was a problem hiding this comment.
don't we need a case for regular int?
There was a problem hiding this comment.
I think for:
var child interface{} = 10
it will go to the default.
There was a problem hiding this comment.
there can't be ints in gitbase, either int32 or int64
jfontan
approved these changes
Oct 16, 2018
mcarmonaa
approved these changes
Oct 16, 2018
|
@erizocosmico can you rebase please? |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/negative-numbers
branch
from
5fcef29
to
aaeecd0
Compare
|
Done |
|
@erizocosmico could you add a test for: |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
|
Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444