This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql/*: fix show tables to match MySQL spec #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
kuba--
approved these changes
Jan 17, 2019
| case *plan.ShowCreateDatabase: | ||
| db, err := a.Catalog.Database(v.Database.Name()) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
This kind of block is almost in every case. Maybe it's good time to extract it to some function.
There was a problem hiding this comment.
But the type is different, so you can't extract it. We could extract the db, err := a.Catalog.Database(v.Database.Name()), but after error handling it would be the same amount of lines, so no point in extracting that either.
The only way I can imagine that we can use to extract this is create an interface that these nodes implement.
type Databaser interface {
Database() sql.Database
WithDatabase(sql.Database) (sql.Node, error)
}There was a problem hiding this comment.
ohh, you're right - it sucks. Let's leave it.
ajnavarro
approved these changes
Jan 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562
SHOW TABLES, which caused an error before even if we had show tables implemented.