This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
YEARWEEK UDF function #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodesp
reviewed
Mar 1, 2019
|
|
||
| // calcDaysInYear calculates days in one year, it works with 0 <= yyyy <= 99. | ||
| func calcDaysInYear(yyyy int32) int32 { | ||
| if (yyyy&3) == 0 && (yyyy%100 != 0 || (yyyy%400 == 0 && (yyyy != 0))) { |
There was a problem hiding this comment.
It looks like a calculation of isLeapYear is it?
erizocosmico
approved these changes
Mar 22, 2019
|
@ajnavarro - done (added to docs + rebase) |
ajnavarro
approved these changes
Apr 11, 2019
|
done |
ajnavarro
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
Closes: #616
The solution was partly taken from tidb.