fix: remove background on octocat #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't agree on this change, it looks like octocat is just floating in midair. The background makes it look like its a "fold" opening. I'd be open to changing the color to something other than hard black though. |
|
I looked into first to see if I could make a line instead that replaced the 45 ° border. Could that be a thing?On 11 Aug 2023, at 10:35, Daniel Berg ***@***.***> wrote:
I don't agree on this change, it looks like octocat is just floating in midair. The background makes it look like its a "fold" opening. I'd be open to changing the color to something other than hard black though.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: ***@***.***>
|
|
Line could work yeah |
|
Tried creating a path in Inkscape, but did not work. Just pushed it for reference. Who thought SVG paths could be so difficult. 🤣 |
MindTooth
force-pushed
the
fix/remove_octocat_bg
branch
from
55b1a0d
to
ffa6312
Compare
@roosta after some playing here https://developer.mozilla.org/en-US/play, I think I got it. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be hard to see, but the black background is IMHO unnecessary. This pull request removed the path rendering the background.