fix: footer positioning, overflow #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR introduced a footer, but this footer would not be at the bottom of the page on larger resolutions (zoom out). This commit fixes that, by using a flex column layout on body along with min height 100vh and growing child container. To achieve this I had set body to a column layout, thereby breaking some width styling in main container. Fixed this by using max-w instead of width and the result is easier to understand, albeit still requires the min-w-0 to be set so that containers shrink correctly. The main element got wrapped in a parent div, so that we can retain the flex direction we want. We want the child to grow in the horizontal but the parent to grow in the vertical.
MindTooth
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the footer positioning by using flex layout, and I had to wrap
<main>with a parent div. In the process I had to fix some issues that cropped up by setting<body>flex direction tocolumn.This PR also fixes a footer overflow issue that resulted in the dreaded horizontal scrollbar.
These were some fairly substantial changes, so I decided to setup a new PR instead of pushing to existing.