New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded inputType and returnType fields of FhirPathFunctions with FHIR_DATA_TYPEs values #238

Open

camemre49 wants to merge 1 commit into main from replace-hardcoded-data-types

+27 −22

Contributor

camemre49 commented Oct 4, 2024

No description provided.

camemre49 force-pushed the replace-hardcoded-data-types branch 2 times, most recently from 475bfd1 to f3b6104 Compare

October 15, 2024 07:47

camemre49 force-pushed the replace-hardcoded-data-types branch from f3b6104 to 97b9dc9 Compare

October 21, 2024 12:08

dogukan10 force-pushed the replace-hardcoded-data-types branch from 97b9dc9 to 60635f2 Compare

October 23, 2024 10:18

Contributor

dogukan10 commented Oct 23, 2024

Please note that this MR does not work. When I call
http://localhost:8085/tofhir/fhir-path-functions, it returns empty input and return types. I think the following function should be updated to handle enumerations: https://github.com/srdc/onfhir/blob/master/onfhir-path/src/main/scala/io/onfhir/path/AbstractFhirPathFunctionLibrary.scala#L44. Marking it as draft.


          ♻️ Refactor: Use FHIR_DATA_TYPES instead of hardcoded values of data …

8e00e23

…types

camemre49 force-pushed the replace-hardcoded-data-types branch from 60635f2 to 8e00e23 Compare

October 25, 2024 07:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet