Improve fhir mapping result #242
Conversation
dogukan10
force-pushed
the
improve-fhir-mapping-result
branch
3 times, most recently
from
7c328ae
to
cda0336
Compare
dogukan10
force-pushed
the
improve-fhir-mapping-result
branch
from
cda0336
to
08ddc88
Compare
|
|
||
| /** | ||
| * Mapping process result | ||
| * Case class representing the result of a FHIR mapping process, extending the base mapping result. |
There was a problem hiding this comment.
Can you please extend the description for this class?
FhirMappingResult class represents a single mappedFhirResource irrespective of how many FHIR resources is created from each row. Hence, different FhirMappingResult instances might be created from a single source row if the mapping is 1-to-many.
| /** | ||
| * If there is a problem in the process, the JSON serialization of the source data | ||
| */ | ||
| val source: String |
There was a problem hiding this comment.
Is the "source" field always populated? Then, I suggest the update the description accordingly.
| * | ||
| * @param mappedFhirResources List of mapped FHIR resources. This is used to group mapped resources by input row. | ||
| */ | ||
| case class FhirMappingResultsForInput( |
There was a problem hiding this comment.
Can you please extend the description for this class?
FhirMappingResultForInput class represents a the result from a single source row, that is each source row corresponds to one FhirMappingResultForInput instance. If the mapping is 1-to-many, mappedFhirResources field includes all the created FHIR resources from the source row.
No description provided.