Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution intermediate errors #79

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Conversation

Okanmercan99
Copy link
Contributor

No description provided.

@Okanmercan99 Okanmercan99 force-pushed the execution-intermediate-errors branch from 91704f2 to 2304788 Compare July 19, 2023 12:56
@dogukan10
Copy link
Contributor

In the logs of FHIRMappingJobResult, we have the following:

2023-07-19_16:01:37.917 [scala-execution-context-global-33] INFO  i.t.e.d.w.SinkHandler$ - toFHIR batch mapping result (PARTIAL_SUCCESS) for execution '80b237fa-d2b4-4663-b949-4c7f03bf4510' of job 'pilot1' in project 'pilot1' for mapping 'https://aiccelerate.eu/fhir/mappings/pilot1/patient-mapping'!
	# of Invalid Rows: 	1
	# of Not Mapped: 	0
	# of FHIR resources:	9
	# of Failed writes:	0

I suggest reordering them as follows:

  • "# of Invalid Rows"
  • "# of Not Mapped"
  • "# of Failed writes"
  • "# of FHIR resources"

Morever, it would be good if we rename # of FHIR resources to # of Written FHIR resources.

WDYT @sinaci @suatgonul @YemreGurses ?

@sinaci
Copy link
Member

sinaci commented Jul 19, 2023

I agree with @dogukan10.

@dogukan10
Copy link
Contributor

While testing this branch, I noticed that we lost the ordering of selected mappings in mapping job execution some time ago.

@Okanmercan99 could you please update https://github.com/srdc/tofhir/blob/main/tofhir-server/src/main/scala/io/tofhir/server/service/ExecutionService.scala#L65 to the following which solves this bug ?

case Some(urls) => urls.flatMap(url => mappingJob.mappings.find(p => p.mappingRef.contentEquals(url)))

@dogukan10 dogukan10 marked this pull request as ready for review July 20, 2023 06:32
@Okanmercan99 Okanmercan99 marked this pull request as draft July 20, 2023 07:30
@dogukan10 dogukan10 marked this pull request as ready for review July 20, 2023 10:02
@suatgonul suatgonul merged commit fbf05c1 into main Jul 20, 2023
1 check passed
@suatgonul suatgonul deleted the execution-intermediate-errors branch July 20, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants