Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: enable migrate msg to be either a struct or an enum #74

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

kakucodes
Copy link
Contributor

Working through a go-codegen failures while trying to generate types for DAODAO's dao_core contract, the root cause seemed to be that go-codegen insists that MigrateMsg is a struct, however for many more mature contracts that is not the case and migration requires an enum so I did the small amount of work to make that allowable and was able to successfully codegen said contract.

@srdtrk
Copy link
Owner

srdtrk commented Jun 4, 2024

Looks good. Will merge after workflows pass. Can you add the problematic schema file into the integration tests as well? All you need to do is drop the file here. And then add it's name here and here

Copy link
Owner

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks so much for the contribution. There seems to be another issue with dao-dao-core contract. So we can add its test once that issue is understood and resolved

@srdtrk srdtrk merged commit cb68050 into srdtrk:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants