feat: forward parent lifecycles to child stages defined on the module #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #68 +/- ##
==========================================
+ Coverage 61.95% 62.05% +0.09%
==========================================
Files 104 104
Lines 6903 6920 +17
==========================================
+ Hits 4277 4294 +17
Misses 2345 2345
Partials 281 281 ☔ View full report in Codecov by Sentry. |
srevinsaju
force-pushed
the
feature/module-lifecycle-forwarding
branch
2 times, most recently
from
b26aeab
to
c7c535e
Compare
In scenarios where lifecycles are defined on the module level, there was an issue preventing the same lifecycle phases from being applied to the child modules. This was very inconvenient when reusing multiple modules and the caller may have custom lifecycle phases, but the module's are not owned by the caller to make changes
srevinsaju
force-pushed
the
feature/module-lifecycle-forwarding
branch
from
c7c535e
to
9fd8308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios where lifecycles are defined on the module level, there was an issue preventing the same lifecycle phases from being applied to the child modules. This was very inconvenient when reusing multiple modules and the caller may have custom lifecycle phases, but the module's are not owned by the caller to make changes