Update readme with codacity badge (#215)

* Update readme with codacity badge * Fix clippy errors * Fix clippy warning
srhickma · Nov 23, 2019 · e0f37dd · e0f37dd
1 parent 1d873a9
commit e0f37dd
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -1,3 +1,4 @@
+[![Codacy Badge](https://api.codacy.com/project/badge/Grade/42b5507d0a5949ada8f63c1fcc1021e6)](https://www.codacy.com/manual/srhickma/padd?utm_source=github.com&amp;utm_medium=referral&amp;utm_content=srhickma/padd&amp;utm_campaign=Badge_Grade)
 [![Build Status](https://travis-ci.com/srhickma/padd.svg?branch=master)](https://travis-ci.com/srhickma/padd)
 [![Test Coverage](https://codecov.io/gh/srhickma/padd/branch/master/graph/badge.svg)](https://codecov.io/gh/srhickma/padd)
 [![Documentation](https://img.shields.io/badge/docs-mkdocs-blue)](https://padd.srhickma.dev)
@@ -91,7 +92,7 @@ grammar {
 }
 ```
 The input:
-```
+```txt
   {  {  {{{ }}}
    {} }  }   { {}
     }

diff --git a/src/cli/formatter.rs b/src/cli/formatter.rs
@@ -143,7 +143,7 @@ pub fn generate_formatter(spec_path: &str) -> Result<Formatter, GenerationError>
 
     let mut sha = Sha256::new();
     sha.input_str(&spec[..]);
-    let spec_sha = sha.result_str().to_string();
+    let spec_sha = sha.result_str();
 
     let fjr_arc = {
         let mut fjr_cache = FJR_CACHE.lock().unwrap();

diff --git a/src/core/parse/earley.rs b/src/core/parse/earley.rs
@@ -656,7 +656,7 @@ impl<Symbol: GrammarSymbol> Parser<Symbol> for EarleyParser {
                         lhs: lex[edge.start].clone(),
                         children: Vec::new(),
                         production: None,
-                        spm: spm.clone(),
+                        spm,
                     },
                     Some(rule) => Tree {
                         lhs: Token::interior(rule.lhs.clone()),
@@ -688,7 +688,7 @@ impl<Symbol: GrammarSymbol> Parser<Symbol> for EarleyParser {
                             Some(production) => Some(production.clone()),
                             None => None,
                         },
-                        spm: spm.clone(),
+                        spm,
                     },
                 }
             }
@@ -895,7 +895,7 @@ impl<Symbol: GrammarSymbol> Parser<Symbol> for EarleyParser {
                         lhs: lex[edge.start].clone(),
                         children: Vec::new(),
                         production: None,
-                        spm: spm.clone(),
+                        spm,
                     },
                     Some(rule) => Tree {
                         lhs: Token::interior(rule.lhs.clone()),
@@ -921,7 +921,7 @@ impl<Symbol: GrammarSymbol> Parser<Symbol> for EarleyParser {
                             Some(production) => Some(production.clone()),
                             None => None,
                         },
-                        spm: spm.clone(),
+                        spm,
                     },
                 }
             }

diff --git a/src/core/spec/gen.rs b/src/core/spec/gen.rs
@@ -480,7 +480,7 @@ where
         formatter_builder.add_pattern(PatternPair {
             production,
             string_production,
-            pattern: pattern_str.to_string(),
+            pattern: (*pattern_str).to_string(),
         })?;
     }
 

diff --git a/src/lib.rs b/src/lib.rs
@@ -326,7 +326,7 @@ grammar {
         //verify
         assert!(res.is_err());
 
-        let mut err: &Error = &res.err().unwrap();
+        let mut err: &dyn Error = &res.err().unwrap();
         assert_eq!(
             format!("{}", err),
             "Failed to parse specification: Parse error: Recognition failed at token 10: \