feat(cli): Allow --override-input to refer to flake name without flake/ prefix of devour_flake
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaraj-bh
force-pushed
the
preprocess-extra-args
branch
from
55b9c8a to
8133612
Compare
shivaraj-bh
changed the title
nix build argsnix build args
The rest of the code, outside of devour_flake.rs, does not need to know about this logic.
Make it happen in the same place, so code remains readable over time.
srid
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
I did some refactor; see commit history for explanation.
Tested it by running ~/code/nixci/result/bin/nixci build -- --override-input ema github:srid/ema on Emanote, which generates:
🐚 nix build '/nix/store/66a9w28f0yrgdy5zgwf8wnxp0n22iahc-source#default' -L --no-link --print-out-paths --override-input flake . --override-input systems github:nix-systems/empty --override-input flake/ema github:srid/ema️
srid
changed the title
nix build args--override-input to refer to flake name without flake/ prefix of devour_flake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #71