generated from srid/rust-nix-template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shell completions #87
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
54edbf4
feat(nixci): add shell completions
rsrohitsingh682 5152d2a
refactor: removed redundant code; call get_config when required
rsrohitsingh682 9a29f1a
refactor: no need for a separate function
rsrohitsingh682 746b9a5
fix: fixed typo
rsrohitsingh682 0e50476
feat(nixci): make shell completion script available after install
rsrohitsingh682 6265e3b
refactor: minor refactor; removed unwanted code
rsrohitsingh682 7f7e135
refactor: remove unused dependency; undo the re-arrangements of imports
rsrohitsingh682 a8f01a6
refactor: remove extra arguments as they don't exist
rsrohitsingh682 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,5 @@ | ||
use std::str::FromStr; | ||
|
||
use anyhow::Result; | ||
use clap::{Parser, Subcommand}; | ||
use colored::Colorize; | ||
use nix_rs::{ | ||
command::NixCmd, | ||
config::NixConfig, | ||
flake::{system::System, url::FlakeUrl}, | ||
}; | ||
|
||
use crate::{ | ||
config, | ||
github::pull_request::{PullRequest, PullRequestRef}, | ||
|
@@ -17,6 +8,14 @@ use crate::{ | |
system_list::{SystemsList, SystemsListFlakeRef}, | ||
}, | ||
}; | ||
use anyhow::Result; | ||
use clap::{Parser, Subcommand}; | ||
use colored::Colorize; | ||
use nix_rs::{ | ||
command::NixCmd, | ||
config::NixConfig, | ||
flake::{system::System, url::FlakeUrl}, | ||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Undo this re-arrangement of imports as it is not necessary for this PR. |
||
|
||
/// A reference to some flake living somewhere | ||
#[derive(Debug, Clone, PartialEq, Eq)] | ||
|
@@ -108,15 +107,17 @@ pub enum Command { | |
#[arg(long, value_parser, value_delimiter = ',')] | ||
systems: Vec<System>, | ||
}, | ||
|
||
/// Generates shell completion scripts | ||
Completion { | ||
#[arg(value_enum)] | ||
shell: clap_complete::Shell, | ||
}, | ||
} | ||
|
||
impl Command { | ||
/// Get the nixci [config::Config] associated with this subcommand | ||
pub async fn get_config(&self, cmd: &NixCmd) -> anyhow::Result<config::Config> { | ||
let flake_ref = match self { | ||
Command::Build(build_cfg) => &build_cfg.flake_ref, | ||
Command::DumpGithubActionsMatrix { flake_ref, .. } => flake_ref, | ||
}; | ||
pub async fn get_config(cmd: &NixCmd, flake_ref: &FlakeRef) -> anyhow::Result<config::Config> { | ||
let url = flake_ref.to_flake_url().await?; | ||
tracing::info!("{}", format!("🍏 {}", url.0).bold()); | ||
let cfg = config::Config::from_flake_url(cmd, &url).await?; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency is no longer used.