Skip to content

Commit

Permalink
Use V8 builtin coverage over nyc (open-telemetry#93)
Browse files Browse the repository at this point in the history
* coverage: use native v8 over nyc

* codecov: use c8 over nyc

* gitignore: remove nyc references
  • Loading branch information
markwolff authored and mayurkale22 committed Jul 11, 2019
1 parent 9d41576 commit 5019fe2
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 13 deletions.
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ lib-cov
# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

Expand Down
4 changes: 2 additions & 2 deletions packages/opentelemetry-context-async-hooks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"types": "build/src/index.d.ts",
"repository": "open-telemetry/opentelemetry-js",
"scripts": {
"test": "nyc ts-mocha -p tsconfig.json test/**/*.ts",
"test": "c8 ts-mocha -p tsconfig.json test/**/*.ts",
"tdd": "yarn test -- --watch-extensions ts --watch",
"clean": "rimraf build/*",
"check": "gts check",
Expand Down Expand Up @@ -40,10 +40,10 @@
"devDependencies": {
"@types/mocha": "^5.2.5",
"@types/node": "^12.0.10",
"c8": "^5.0.1",
"codecov": "^3.1.0",
"gts": "^1.0.0",
"mocha": "^6.1.0",
"nyc": "14.0.0",
"ts-mocha": "^6.0.0",
"ts-node": "^8.0.0",
"typescript": "^3.4.5"
Expand Down
8 changes: 4 additions & 4 deletions packages/opentelemetry-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
"repository": "open-telemetry/opentelemetry-js",
"scripts": {
"test": "yarn test:node && yarn test:browser",
"test:node": "nyc ts-mocha -p tsconfig.json test/**/*.ts",
"test:node": "c8 ts-mocha -p tsconfig.json test/**/*.ts",
"test:browser": "karma start --single-run",
"tdd": "yarn tdd:node",
"tdd:node": "yarn test -- --watch-extensions ts --watch",
"tdd:browser": "karma start",
"codecov": "nyc report --reporter=json && codecov -f coverage/*.json",
"codecov": "c8 report --reporter=json && codecov -f coverage/*.json",
"clean": "rimraf build/*",
"check": "gts check",
"compile": "tsc -p .",
Expand All @@ -42,7 +42,7 @@
"LICENSE",
"README.md"
],
"nyc": {
"c8": {
"extension": [
".ts"
],
Expand All @@ -64,6 +64,7 @@
"@types/mocha": "^5.2.5",
"@types/node": "^10.12.12",
"@types/webpack-env": "1.13.9",
"c8": "^5.0.1",
"codecov": "^3.1.0",
"gts": "^1.0.0",
"karma": "^4.1.0",
Expand All @@ -72,7 +73,6 @@
"karma-spec-reporter": "^0.0.32",
"karma-webpack": "^4.0.2",
"mocha": "^6.1.0",
"nyc": "^14.0.0",
"ts-loader": "^6.0.4",
"ts-mocha": "^6.0.0",
"ts-node": "^8.0.0",
Expand Down
8 changes: 4 additions & 4 deletions packages/opentelemetry-scope-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"types": "build/src/index.d.ts",
"repository": "open-telemetry/opentelemetry-js",
"scripts": {
"test": "nyc ts-mocha -p ./tsconfig.json test/**/*.ts",
"tdd": "yarn run test -- --watch-extensions ts --watch",
"codecov": "nyc report --reporter=json && codecov -f coverage/*.json",
"test": "c8 ts-mocha -p tsconfig.json test/**/*.ts",
"tdd": "yarn test -- --watch-extensions ts --watch",
"codecov": "c8 report --reporter=json && codecov -f coverage/*.json",
"clean": "rimraf build/*",
"check": "gts check",
"compile": "tsc -p .",
Expand Down Expand Up @@ -40,10 +40,10 @@
},
"devDependencies": {
"@types/mocha": "^5.2.5",
"c8": "^5.0.1",
"codecov": "^3.1.0",
"gts": "^1.0.0",
"mocha": "^6.1.0",
"nyc": "14.0.0",
"ts-mocha": "^6.0.0",
"ts-node": "^8.0.0",
"typescript": "^3.4.5"
Expand Down

0 comments on commit 5019fe2

Please sign in to comment.