Skip to content

Commit

Permalink
chore: code cleanup (open-telemetry#256)
Browse files Browse the repository at this point in the history
* chore: code cleanup

* fix: build
  • Loading branch information
mayurkale22 authored Sep 15, 2019
1 parent b125521 commit 84567f5
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 45 deletions.

This file was deleted.

11 changes: 0 additions & 11 deletions packages/opentelemetry-node-tracer/src/instrumentation/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,6 @@
import { Logger } from '@opentelemetry/types';
import * as path from 'path';
import * as semver from 'semver';
import * as constants from './constants';

/**
* Gets the default package name for a target module. The default package
* name uses the default scope and a default prefix.
* @param moduleName The module name.
* @returns The default name for the package.
*/
export function defaultPackageName(moduleName: string): string {
return `${constants.OPENTELEMETRY_SCOPE}/${constants.DEFAULT_PLUGIN_PACKAGE_NAME_PREFIX}-${moduleName}`;
}

/**
* Gets the package version.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,6 @@ describe('Instrumentation#utils', () => {
utils.searchPathForTest(INSTALLED_PLUGINS_PATH);
});

describe('defaultPackageName', () => {
it('should return package name with default scope and a prefix', () => {
assert.strictEqual(
utils.defaultPackageName('http'),
'@opentelemetry/plugin-http'
);
assert.strictEqual(
utils.defaultPackageName('simple-module'),
'@opentelemetry/plugin-simple-module'
);
});
});

describe('getPackageVersion', () => {
it('should handle when undefined basedir', () => {
assert.strictEqual(utils.getPackageVersion(logger), null);
Expand Down

0 comments on commit 84567f5

Please sign in to comment.