Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix protoc-gen-gotag in bsr by updating its googleapi dependency #33

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

theFong
Copy link
Contributor

@theFong theFong commented Sep 6, 2022

You may need to upgrade your googleapis/googleapis dependency.
https://github.com/googleapis/googleapis contains over 3800 files, mostly
relating to Google's core APIs. However, there are only ~30 files used by
99.999%% of developers, and these files are the most common dependency in
the Protobuf ecosystem. This hosted module now only includes these specific
files, as including all the files causes hundreds of megabytes of unused
generated code for the vast majority of developers.
Before taking the BSR out of beta, we slimmed down googleapis from the ~3800
files to these common ~30 files. Having all ~3800 files caused many
issues for our consumers, with no benefit. Considering this, we made the
decision to trim down the module so we can ensure the best experience for our
users as we finalize v1.
At Buf, we take breaking changes incredibly seriously. This was done to ensure
the stability of the BSR as we move out of beta. We will never break consumers
after v1.
We apologize for any disruption this may cause, however we felt this
issue was serious enough to make this change prior to finalizing the BSR beta.
The mitigation for you is likely just to run:
buf mod update
This will bring you to the most recent commit of the updated googleapis module.
If you've pinned your googleapis dependency, you'll need to remove the pin and
update to a new pin with a reference from
https://buf.build/googleapis/googleapis.

@theFong
Copy link
Contributor Author

theFong commented Sep 7, 2022

For anyone wanting a quick fix, I have pushed a bsr with a fix here. https://buf.build/brevdev/protoc-gen-gotag

@srikrsna srikrsna merged commit 7476140 into srikrsna:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants