Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup fails when bind files are no longer available #2298

Closed
jbemmel opened this issue Nov 17, 2024 · 3 comments · Fixed by #2334 or #2337
Closed

Cleanup fails when bind files are no longer available #2298

jbemmel opened this issue Nov 17, 2024 · 3 comments · Fixed by #2334 or #2337

Comments

@jbemmel
Copy link
Contributor

jbemmel commented Nov 17, 2024

During sudo clab destroy --cleanup -t lab.yml:

Error: failed to verify bind path: stat /home/jeroen/Projects/netlab/tests/clab_files/xr/daemons: no such file or directory

Such errors aren't critical when doing 'destroy', and shouldn't stop the process

@hyposcaler-bot
Copy link
Contributor

hyposcaler-bot commented Nov 18, 2024

Looked at this to just understand the flow for destroy.

a side effect of cmd.destroyFn() calling clab.NewContainerLab() to parse the topology is that clab.resolveBindPaths() eventually gets called.

clab.resolveBindPaths() kicks the error if os.stat() errors on the path.

@hellt
Copy link
Member

hellt commented Nov 22, 2024

yes, this needs to be addressed
like a parameter to the NewContainerlab that would switch off validations. Destroy routine should set it

@hellt
Copy link
Member

hellt commented Dec 6, 2024

fixed. Will be available in the next patch or major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants