Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use the skip binds check #2337

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Properly use the skip binds check #2337

merged 1 commit into from
Dec 7, 2024

Conversation

hellt
Copy link
Member

@hellt hellt commented Dec 7, 2024

fix #2298 for good

@hellt hellt merged commit de44258 into main Dec 7, 2024
67 checks passed
@hellt hellt deleted the skip-binds-check-v2 branch December 7, 2024 14:28
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.84%. Comparing base (c25b2f4) to head (f605205).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2337      +/-   ##
==========================================
+ Coverage   51.82%   51.84%   +0.01%     
==========================================
  Files         172      172              
  Lines       16987    16994       +7     
==========================================
+ Hits         8803     8810       +7     
  Misses       7262     7262              
  Partials      922      922              
Files with missing lines Coverage Δ
clab/config.go 67.08% <100.00%> (+0.33%) ⬆️
cmd/destroy.go 77.63% <100.00%> (+0.45%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup fails when bind files are no longer available
1 participant