-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate SSH config #1660
Merged
Merged
Generate SSH config #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set the Usernaem for the nodes - Set StrictHostKeyChecking=no - Set UserKnownHostsFile=/dev/null
@steiler thanks for this, good quality of life improvement IMO |
lgtm |
make Username optional silence ssh config removal not exists error
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1660 +/- ##
==========================================
+ Coverage 50.96% 51.15% +0.18%
==========================================
Files 136 137 +1
Lines 13188 13239 +51
==========================================
+ Hits 6721 6772 +51
+ Misses 5726 5721 -5
- Partials 741 746 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate SSH config that:
Been thinking of using wildcard match, but in case the prefix of nodes is set to ""
The Names would not have a prefix name of "clab-" anymore. So going with individual entries is the best option.
Implementing #1659