Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust labdir acls #1701

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Adjust labdir acls #1701

merged 7 commits into from
Nov 7, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Nov 6, 2023

We adjust the Lab Dir ACL to be rwx by the SUDO_UID and SUDO_GID.
We also adjust the Default ACL such that all the subsequently created files and folders do inherit the default entries.

@steiler steiler marked this pull request as ready for review November 6, 2023 15:48
@steiler steiler requested a review from hellt November 6, 2023 15:48
@hellt hellt self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1701 (3df5ccf) into main (f8ad48e) will decrease coverage by 0.06%.
The diff coverage is 39.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
- Coverage   51.75%   51.69%   -0.06%     
==========================================
  Files         141      141              
  Lines       13700    13743      +43     
==========================================
+ Hits         7090     7105      +15     
- Misses       5836     5855      +19     
- Partials      774      783       +9     
Files Coverage Δ
cmd/deploy.go 64.62% <50.00%> (-0.67%) ⬇️
utils/file.go 55.29% <37.50%> (-3.32%) ⬇️

@hellt hellt merged commit 7c5d4fe into srl-labs:main Nov 7, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants