Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DownloadFile func in favor of CopyFile #1705

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Remove DownloadFile func in favor of CopyFile #1705

merged 1 commit into from
Nov 7, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Nov 7, 2023

thnx for spotting this @steiler

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1705 (0a9c987) into main (31220cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   51.69%   51.70%   +0.01%     
==========================================
  Files         141      141              
  Lines       13718    13700      -18     
==========================================
- Hits         7091     7084       -7     
+ Misses       5853     5841      -12     
- Partials      774      775       +1     
Files Coverage Δ
clab/clab.go 76.59% <100.00%> (ø)
utils/file.go 58.60% <ø> (+2.81%) ⬆️

... and 2 files with indirect coverage changes

@hellt hellt merged commit f8ad48e into main Nov 7, 2023
21 checks passed
@hellt hellt deleted the use-copy-file branch November 7, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant