Fixing Test related to SRL 23.10 #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix tests
hellt
reviewed
Nov 10, 2023
nodes/srl/srl.go
Outdated
Comment on lines
603
to
610
| if len(n.sshPubKeys) > 0 && (semver.Compare(n.swVersion.String(), "v23.10") >= 0 || n.swVersion.major == "0") { | ||
| tplData.SSHPubKeys = catenateKeys(n.sshPubKeys) | ||
| } else { | ||
| // prior to 23.10.1 only rsa keys are supported | ||
| // this function filters out non-rsa keys from the | ||
| // list of ssh public keys found on the system/agent | ||
| n.filterSSHPubKeys() | ||
| } |
There was a problem hiding this comment.
@steiler I brought back the filtering function since it is required for SRL < 23.10.1
There was a problem hiding this comment.
I am dumb. Filtering is not needed as now we support all types of keys in the config in 23.10, and older releases use mounted files, where, again, all keys can be put.
hellt
approved these changes
Nov 10, 2023
This reverts commit 603c32d.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
+ Coverage 51.60% 51.72% +0.11%
==========================================
Files 141 141
Lines 13759 13762 +3
==========================================
+ Hits 7100 7118 +18
+ Misses 5870 5858 -12
+ Partials 789 786 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix tests