Fixing nil pointer deref on Scrapli send config errors #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellt
reviewed
Nov 14, 2023
Comment on lines
+288
to
+289
| if mr != nil { | ||
| return fmt.Errorf("failed to apply config; error: %+v %+v", err, mr.Failed) |
There was a problem hiding this comment.
this one is not needed, as we check for mr != nil above
There was a problem hiding this comment.
thats not correct.
its an OR up there ... we could do it in to seperate branches but ... same same
There was a problem hiding this comment.
then here it shoudl also be if mr != nil && err != nil
otherwise the statement above might have err == nil, but mr.Failed != nil
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
+ Coverage 51.51% 51.56% +0.04%
==========================================
Files 142 143 +1
Lines 13776 13805 +29
==========================================
+ Hits 7097 7118 +21
- Misses 5891 5896 +5
- Partials 788 791 +3
|
|
fix verified, thanks @steiler ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.