Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting ssh key indexes to start from max (32) to go backwards #1724

Merged
merged 4 commits into from
Nov 18, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Nov 14, 2023

No description provided.

@steiler steiler marked this pull request as ready for review November 14, 2023 14:43
@steiler steiler requested a review from hellt November 14, 2023 14:43
Copy link
Member

@hellt hellt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steiler check the two commits I added. They are just test refactoring, so I believe you won't have objections to that.

Thanks for picking this up, looks good.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #1724 (ba4e40d) into main (2184f2d) will increase coverage by 0.28%.
Report is 3 commits behind head on main.
The diff coverage is 87.09%.

❗ Current head ba4e40d differs from pull request most recent head 3ebf833. Consider uploading reports for the commit 3ebf833 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
+ Coverage   51.55%   51.83%   +0.28%     
==========================================
  Files         143      143              
  Lines       13807    13794      -13     
==========================================
+ Hits         7118     7150      +32     
+ Misses       5898     5852      -46     
- Partials      791      792       +1     
Files Coverage Δ
nodes/vr_sros/vr-sros.go 0.52% <ø> (+<0.01%) ⬆️
nodes/vr_sros/sshKey.go 52.94% <87.09%> (+52.94%) ⬆️

... and 2 files with indirect coverage changes

@hellt hellt merged commit 17edf5c into srl-labs:main Nov 18, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants