Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve labdir from container labels during destroy #1738

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Nov 22, 2023

We where always expecting the labdir to be a subdir of the actual pwd. With this PR we will query the labels and deduce the labdir from the "containerlab" label.

Fixing #1737

We where always expecting the labdir to be a subdir of the actual pwd.
With this PR we will query the labels and deduce the labdir from the "containerlab" label.
@hellt
Copy link
Member

hellt commented Nov 23, 2023

Thanks for checking this out! Mark it ready when you are.
May be a need for 0.48.4 :D

@steiler steiler marked this pull request as ready for review November 23, 2023 09:11
@hellt hellt changed the title Destroy all: retrieve labdir from container labels Retrieve labdir from container labels during destroy Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #1738 (62f8290) into main (c02c840) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 77.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
- Coverage   51.87%   51.85%   -0.02%     
==========================================
  Files         143      143              
  Lines       13845    13898      +53     
==========================================
+ Hits         7182     7207      +25     
- Misses       5864     5883      +19     
- Partials      799      808       +9     
Files Coverage Δ
clab/config.go 66.83% <100.00%> (ø)
utils/file.go 54.91% <100.00%> (+0.61%) ⬆️
types/topo_paths.go 69.42% <57.14%> (-1.02%) ⬇️
cmd/destroy.go 67.50% <77.61%> (-2.57%) ⬇️

... and 3 files with indirect coverage changes

@hellt hellt merged commit 27fad67 into srl-labs:main Nov 23, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants