Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial OpenBSD support #1762

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Initial OpenBSD support #1762

merged 4 commits into from
Dec 7, 2023

Conversation

dteslya
Copy link
Contributor

@dteslya dteslya commented Dec 3, 2023

This PR follows hellt/vrnetlab#151 and adds OpenBSD support. I've included an example lab topology I used for testing and some basic documentation.

Dmitry Teslya and others added 2 commits December 3, 2023 10:02
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1762 (bfa53d3) into main (46bd91f) will decrease coverage by 0.29%.
Report is 8 commits behind head on main.
The diff coverage is 3.50%.

❗ Current head bfa53d3 differs from pull request most recent head 2414123. Consider uploading reports for the commit 2414123 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1762      +/-   ##
==========================================
- Coverage   51.99%   51.71%   -0.29%     
==========================================
  Files         144      145       +1     
  Lines       13967    14024      +57     
==========================================
- Hits         7262     7252      -10     
- Misses       5894     5957      +63     
- Partials      811      815       +4     
Files Coverage Δ
clab/register.go 100.00% <100.00%> (ø)
cmd/generate.go 65.47% <ø> (ø)
nodes/vr_openbsd/vr-openbsd.go 1.78% <1.78%> (ø)

... and 4 files with indirect coverage changes

@hellt hellt merged commit ee3ef23 into srl-labs:main Dec 7, 2023
20 checks passed
@hellt
Copy link
Member

hellt commented Dec 7, 2023

Thanks @dteslya

@hellt
Copy link
Member

hellt commented Dec 7, 2023

The new release will have this change, but for the time being users who interested in this kind can download the binary with

sudo docker run --rm -v $(pwd):/workspace ghcr.io/oras-project/oras:v1.1.0 pull ghcr.io/srl-labs/clab-oci:24141233

@dteslya dteslya deleted the add-openbsd branch December 7, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants