-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vJunosEvolved #1775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akielaries thanks
You also have to add the line to mkdocs.yml
file for the article to render in the list of kinds and lab examples
you can also refresh the main branch and rebase your commits on top of it to resolve the testing issue with border0 failure. |
Sure thing. I added the vJunosEvolved manual link to the README, a lab-example doc under docs/lab-examples/srl-vjunosevolved.md, and the proper lines in the |
@akielaries would you be willing to also make the ssh keys available in the config? |
…b-example to reference upcoming release of clab
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
- Coverage 51.42% 51.24% -0.19%
==========================================
Files 145 146 +1
Lines 14132 14187 +55
==========================================
+ Hits 7268 7270 +2
- Misses 6046 6098 +52
- Partials 818 819 +1
|
@hellt Sure thing! I went ahead and updated the clab version in the vJunosEvolved lab example doc and removed the vr- prefixes found in references to vJunosEvolved and vJunos-switch. @steiler I see how the SROS node is doing this but what entry within the lab's |
In the pre deploy phase you get all the keys we find... *.pub files, agent registered once etc. In srl /sros we install them all for the relevant user. |
Thanks @akielaries |
Corresponding PR from hellt/vrnetlab for adding support for Juniper's vJunosEvolved, a virtual instance using PTX10001 as the reference. I used the below file to test and added as a lab example under
srlvjunos02
: