Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Cisco FTDv support #1783

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Initial Cisco FTDv support #1783

merged 5 commits into from
Dec 13, 2023

Conversation

dteslya
Copy link
Contributor

@dteslya dteslya commented Dec 12, 2023

This PR follows hellt/vrnetlab#154 and adds Cisco FTDv support. I've included an example lab topology I used for testing and some basic documentation.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #1783 (747e40f) into main (40084e3) will decrease coverage by 0.18%.
Report is 2 commits behind head on main.
The diff coverage is 4.87%.

❗ Current head 747e40f differs from pull request most recent head 4774684. Consider uploading reports for the commit 4774684 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
- Coverage   51.45%   51.27%   -0.18%     
==========================================
  Files         145      146       +1     
  Lines       14132    14173      +41     
==========================================
- Hits         7271     7267       -4     
- Misses       6044     6086      +42     
- Partials      817      820       +3     
Files Coverage Δ
clab/register.go 100.00% <100.00%> (ø)
cmd/generate.go 65.47% <ø> (ø)
nodes/vr_ftdv/vr-ftdv.go 2.50% <2.50%> (ø)

... and 1 file with indirect coverage changes

@hellt hellt merged commit c777995 into srl-labs:main Dec 13, 2023
6 of 7 checks passed
@dteslya dteslya deleted the add-ftdv branch December 14, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants