Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Definition: Move Certificate SAN under Certificate stanza #1821

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Jan 15, 2024

Implement #1815

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be855fa) 51.27% compared to head (452cc58) 51.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1821      +/-   ##
==========================================
- Coverage   51.27%   51.23%   -0.05%     
==========================================
  Files         147      147              
  Lines       14273    14266       -7     
==========================================
- Hits         7319     7309      -10     
- Misses       6134     6137       +3     
  Partials      820      820              
Files Coverage Δ
clab/config.go 66.58% <ø> (-0.09%) ⬇️
nodes/default_node.go 57.87% <100.00%> (+0.78%) ⬆️
nodes/srl/srl.go 58.26% <100.00%> (-0.32%) ⬇️
types/node_definition.go 94.89% <ø> (-0.11%) ⬇️
types/topology.go 68.23% <ø> (+0.26%) ⬆️
types/types.go 63.15% <100.00%> (+0.99%) ⬆️

... and 1 file with indirect coverage changes

@hellt hellt merged commit 475cd42 into main Jan 17, 2024
54 of 56 checks passed
@hellt hellt deleted the sanundercert branch January 17, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants