Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect partial configs (partial config and ssh keys) before appying #1919

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Feb 29, 2024

fixing #1916 by collecting the partial config and ssh keys in a buffer before deploying it altogether.

@steiler steiler requested a review from hellt February 29, 2024 15:51
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 53.73%. Comparing base (f2b4a62) to head (d147574).
Report is 231 commits behind head on main.

❗ Current head d147574 differs from pull request most recent head e6ade6b. Consider uploading reports for the commit e6ade6b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
+ Coverage   48.59%   53.73%   +5.13%     
==========================================
  Files         133      155      +22     
  Lines       12789    11276    -1513     
==========================================
- Hits         6215     6059     -156     
+ Misses       5870     4352    -1518     
- Partials      704      865     +161     
Files Coverage Δ
nodes/vr_sros/sshKey.go 54.54% <0.00%> (ø)
nodes/vr_sros/vr-sros.go 40.26% <50.00%> (+39.68%) ⬆️

... and 125 files with indirect coverage changes

@hellt hellt merged commit 4735005 into main Mar 1, 2024
60 checks passed
@hellt hellt deleted the DuplicateLogSROSpartialApply branch March 1, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants